Anope IRC Services

Please login or register.

Login with username, password and session length
Advanced search  

News:

Pages: [1]   Go Down

Author Topic: Separate Memoserv's DB from nick and chan db  (Read 9420 times)

0 Members and 1 Guest are viewing this topic.

someone

  • Anope User
  • Offline Offline
  • Gender: Male
  • Posts: 42
    • http://www.somenet.org
Separate Memoserv's DB from nick and chan db
« on: November 13, 2007, 09:26:14 AM »

Why?

ppl could easier set a global memo limit, based on the filesize.
like 10mb and not a byte more memos.

if implemented well, you could say: everyone has 1000 memos, but only as long as all memos dont exceed 10 mb^^

It would make it also easier to delete all memos at one, without affecting the nicks and chans the memos were send to
Logged

n00bie

  • Anope User
  • Offline Offline
  • Gender: Male
  • Posts: 411
(No subject)
« Reply #1 on: November 13, 2007, 09:54:08 AM »

My point for having a seperate memo db's for nick and chan is that, when sending a memos to a channel, after a person has finished reading the memos and assuming that he have the required access to delete the channel memos, the channel memos got deleted and other person who haven't read the channel memos yet didn't know that a channel memo was there before. I hope you understand my point.
Logged
I am always doing things that which I cannot do, in order that I may learn how to do it.

someone

  • Anope User
  • Offline Offline
  • Gender: Male
  • Posts: 42
    • http://www.somenet.org
(No subject)
« Reply #2 on: November 14, 2007, 12:04:42 AM »

if someone deletes a chann memo, its deleted, if some user didnt read it, he wont - this is the current behaviour and i dont see, why this should change - i just stated, that it would be better to move the memos to another file and separate them from nicks and chans.db

on the other hand: if you want to delete ALL memos, you could delete the memodb, what would keep all nicks and channels...
... but maybe you wanted to say something diffrent - than sry- i didnt got it...


Current behaviour:
USER 1
[01:28:46] -MemoServ- There is a new memo on channel ##.
[01:28:46] -MemoServ- Type /msg MemoServ READ ## 1 to read it.
[01:28:53] -> *MemoServ* READ ## 1
[01:28:53] -MemoServ- Memo 1 from Someone (...).  To delete, type: /msg MemoServ DEL ## 1
[01:28:53] -MemoServ- test
[01:28:56] -> *MemoServ* DEL ## 1
[01:28:56] -MemoServ- Memo 1 has been deleted.

USER 2
[01:28:46] -MemoServ- Type /msg MemoServ READ ## 1 to read it.
[01:29:04] -> *MemoServ* READ ## 1
// MEMO WAS ALREADY DELETED BY USER 1
[01:29:04] -MemoServ- ## has no memos.
Logged

katsklaw

  • Guest
(No subject)
« Reply #3 on: November 14, 2007, 11:23:28 AM »

The way channel memos work is going to be fixed in the next development branch of Anope. So it's already on the "to do" list.
Logged

someone

  • Anope User
  • Offline Offline
  • Gender: Male
  • Posts: 42
    • http://www.somenet.org
(No subject)
« Reply #4 on: November 14, 2007, 11:34:52 AM »

nice^^
and dont forget to split the files :P
as it doesnt really matther where stuff is stored, and it would make things easier^^
Logged

katsklaw

  • Guest
(No subject)
« Reply #5 on: November 14, 2007, 08:30:50 PM »

since it doesn't really matter where it's stored, then there is no reason to change it's current location.
Logged

Trystan Scott Lee

  • Contributor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 343
(No subject)
« Reply #6 on: November 14, 2007, 10:44:11 PM »

Perphas a suggestion for the future when the new db format is introduced
Logged
my God my tourniquet, return to me salvation

katsklaw

  • Guest
(No subject)
« Reply #7 on: November 14, 2007, 10:49:23 PM »

perhaps, however it won't be Anope1.8 stable as the next stable branch will be backwards compatable with 1.6
Logged

kusau

  • Anope User
  • Offline Offline
  • Posts: 2
    • http://www.gamingcomm.com
(No subject)
« Reply #8 on: April 17, 2008, 05:16:32 AM »

I've had memos stored in the nick db file cause Anope to crash. There was no way to delete the specific memo so users containing these 'devil' memos had to be dropped. Otherwise each time they'd try to read a memo services would crash. This happend on TWO users of my network.

They told me that memoserv said there was a memo waiting to be read (from some date before they were born) and after retrieving the memo which was blank (besides the date) services would crash.

Having memo db files OUTSIDE the nick db files would prevent having to drop users to correct this.  Most of my users agree that they'd rather have to loose a memo then lose their nick and all channels registered so that services wouldn't have to crash.
Logged

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
(No subject)
« Reply #9 on: April 17, 2008, 08:40:41 AM »

anope shouldn't crash in the first place... instead of trying to contain the consequences it would be better to avoid the crash in the first place...

and i guess the 'devil' memo was set by a module or so cause i haven't heard of anope core crashing on memos whereas i do know that certain modules don't handle it properly...
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)

katsklaw

  • Guest
(No subject)
« Reply #10 on: April 17, 2008, 11:51:21 AM »

1> As I said earlier, it won't happen before Anope 1.8.
2> Having memos in the nick.db does NOT cause any crashes. memos have ALWAYS been stored in nick.db.
3> Continuing this conversation is counter productive since no db changes will be made prior to Anope 1.8
Logged
Pages: [1]   Go Up