Anope IRC Services

Please login or register.

Login with username, password and session length
Advanced search  

News:

Pages: [1]   Go Down

Author Topic: ChanServ extra spaces in the Topic  (Read 12020 times)

0 Members and 1 Guest are viewing this topic.

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
ChanServ extra spaces in the Topic
« on: January 02, 2007, 02:46:40 AM »

ChanServ does not include the extra spaces in the room Topic when it puts on the Topic


ooooo <space> <space> <space> TOPIC <space> <space> <space> ooooo


space - spacebar




ChanServ takes out the extra spaces when it puts on the Topic and makes it as


ooooo <space> TOPIC <space> ooooo




Can ChanServ be made so it will include the extra spaces when it puts on the Topic

[Edited on 4-1-2007 by Casey]

[Edited on 5-1-2007 by Casey]
Logged

Jobe

  • Contributor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1023
    • Anope IRC Services
(No subject)
« Reply #1 on: January 02, 2007, 10:56:20 AM »

To be honest i cant see any reason to need more then one space.
Logged
Your IP: ()
My IRC Status:

Come along and visit http://www.anopequotes.org/

katsklaw

  • Guest
(No subject)
« Reply #2 on: January 02, 2007, 12:31:08 PM »

It's not ChanServ, it's your IRCd. they strip out extra spaces as they are not needed for any sane purpose. Although RFC1459 doesn't limit spaces in the topic, IRCds will still strip them for sanity and efficiency reasons.
Logged

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
(No subject)
« Reply #3 on: January 03, 2007, 12:09:24 AM »

Thought it was ChanServ doing that - is the IRCd -- Unreal

I posted a module request in Unreal which I have a feeling that it cannot be done only by going into the code.  I really hope it can be done.

It looks nice having the extra spaces in the Topic instead of it being squeezed in all together.
Logged

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
(No subject)
« Reply #4 on: January 03, 2007, 12:54:10 AM »

you can trick unreal into displaying the spaces by putting color cores in between the spaces...
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
(No subject)
« Reply #5 on: January 03, 2007, 01:14:15 AM »

Unreal is saying that it is not an IRCd issue

http://forums.unrealircd.com/viewtopic.php?t=4057



TOPIC
Code: [Select]
14-æ0,14æ¸1,14`æ14,1æ¸5,1`æ1,5æ¸0,5 -=   #Australia   *   The Land of Australia   =- 1,5¸æ5,1æ`14,1¸æ1,14æ`0,14¸æ14,0æ-
Logged

katsklaw

  • Guest
(No subject)
« Reply #6 on: January 03, 2007, 02:16:43 AM »

Yeah, sorry for the misinformation. It' was my CLIENT that was stripping the spaces.

I still think there shouldn't be alot of spaces in the topic for sanity reasons. filling up the channel topic with blank space just wastes resources at the expense of the users bordom and shouldn't be allowed. Please understand that spaces are still legal characters and take up space bitwise and having a database full of blank space is ... well, insane ;)
Logged

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
(No subject)
« Reply #7 on: January 03, 2007, 02:43:02 AM »

What about a module to be made for those that would like it ? - not built into the core services
Logged

katsklaw

  • Guest
(No subject)
« Reply #8 on: January 03, 2007, 05:57:06 AM »

not sure, a dev team member would likely have to answer that.
Logged

djGrrr

  • Anope User
  • Offline Offline
  • Posts: 51
    • http://www.p2p-network.net/
(No subject)
« Reply #9 on: January 03, 2007, 03:23:12 PM »

Mirc does this automatically, the proper way around it is to use 2 different types of spaces (like in a proper MOTD) the standard space, and ascii char 160 $chr(160) in mirc
Logged
P2P-NET Network Staff

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
(No subject)
« Reply #10 on: January 04, 2007, 09:57:20 AM »

have changed the title to be a Module Request - not in the core

and if it could be moved over to the Modules section
Logged

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
(No subject)
« Reply #11 on: January 04, 2007, 11:22:52 AM »

i doubt a module can do this....
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)

djGrrr

  • Anope User
  • Offline Offline
  • Posts: 51
    • http://www.p2p-network.net/
(No subject)
« Reply #12 on: January 04, 2007, 02:38:16 PM »

Quote
Originally posted by Viper
i doubt a module can do this....

it can't, this has nothing to do with services, its the IRC Client that strips the spaces (unless you do it the way i mentioned)
Logged
P2P-NET Network Staff

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
(No subject)
« Reply #13 on: January 04, 2007, 08:28:13 PM »

On DALnet it does have the extra spaces

I tried Auspice Services on myself and it did put the extra spaces in


Code: [Select]
* ChanServ changes topic to '14-æ0,14æ¸1,14`æ14,1æ¸5,1`æ1,5æ¸0,5 -=   #Australia   *   The Land of Australia   =- 1,5¸æ5,1æ`14,1¸æ1,14æ`0,14¸æ14,0æ- (Casey) (Casey)'
Logged

katsklaw

  • Guest
(No subject)
« Reply #14 on: January 04, 2007, 09:51:29 PM »

this is not a client issue .. yes mirc strips spaces however not everyone uses mIRC and for those that don't use mIRC, can definately set topics with alot of spaces between words.

Topic set with a client other than mIRC:
*** katslaw changes topic to: 'gfdfg                   ergthdad ff e   r                                                     wedf          gh'

Topic set with chanserv:
/cs topic #blahness gfdfg                   ergthdad ff e   r                                                     wedf          gh

Chanserv replies (x bein a BS bot):
 *** x changes topic to: 'gfdfg'

So ChanServ *IS* stripping spaces out. The question is: Is this really a bug or intended behaviour.

Casey, please report this as a bug at: http://bugs.anope.org


Staff Note: This forum strips extra spaces as well, again in my opinion, a very sane thing to do.

[Edited on 4-1-2007 by katsklaw]
Logged

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
(No subject)
« Reply #15 on: January 04, 2007, 10:35:05 PM »

I have posted the Bug Report - 658
Logged

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
(No subject)
« Reply #16 on: January 05, 2007, 01:38:51 AM »

taken out the Module Request from the title - not a module request -- bug report
Logged

Trystan Scott Lee

  • Contributor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 343
(No subject)
« Reply #17 on: January 05, 2007, 02:50:12 AM »

This is NOT a bug but a design choose made way back before Anope used SVN (can't find whom commited doclearbuf().. was added before svn).. this prevents a user from crafting a message of all spaces and sending it to services and crashing them.

Why not filter for TOPIC command? well TOPIC is not set the same on all ircd and thus add logic in the core to look for strings and parse them up.
Logged
my God my tourniquet, return to me salvation

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
(No subject)
« Reply #18 on: January 05, 2007, 06:09:34 AM »

It would be really nice for the topic to include the extra spaces.

It does not look as nice when you do a nice topic and it is squeezed in together.
Logged

katsklaw

  • Guest
(No subject)
« Reply #19 on: January 05, 2007, 07:32:02 AM »

"nice" is not a reason to compromise security or stability. there really is no real or practical reason for allowing massive spaces between words in a channel topic, I'm sorry .. there just isn't. Based on my expereince, users rarely even read the topic to begin with.

As far as "squeezed in together" goes, a properly formatted sentance only has 1 space between words to start with, not 5 or 10. The human brain is very capable of accepting a single space because that is how we write. So single spacing is not squeezing anything at all.
Logged

Jobe

  • Contributor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1023
    • Anope IRC Services
(No subject)
« Reply #20 on: January 05, 2007, 11:56:53 PM »

Im with katsklaw on this, there is no acceptable need for more then one space between words. If you need more, use other characters such as a hyphen (-)
Logged
Your IP: ()
My IRC Status:

Come along and visit http://www.anopequotes.org/

katsklaw

  • Guest
(No subject)
« Reply #21 on: January 08, 2007, 03:57:01 AM »

As an update, a bug report was filed on this topic and it's on the table for discussion as to what we will do with it.
Logged
Pages: [1]   Go Up