Anope IRC Services

Anope Support => 2.0.x/1.9.x Support => Topic started by: lordcow on February 22, 2012, 01:37:41 PM

Title: upgrading database to 1.9.6
Post by: lordcow on February 22, 2012, 01:37:41 PM

Hi all, we recently upgraded from 1.8.7 to 1.9.6 (on InspIRCd 2.0.5) but we lose data after a restart. We followed the cues in the .conf, loading with:

module { name = "db_old" }
#module { name = "db_plain" }
module { name = "db_flatfile" }

This correctly loaded the data from 1.8.7, and when we /operserv update or shutdown it correctly wrote everything to the new anope.db. On shutdown we hashed out the db_old module and started up to find all memos had disappeared (amongst possibly some other data). Once anope wrote to disk again the memos that had been in the new anope.db file were cleared. Is this a bug or are we doing something wrong?

Title: Re: upgrading database to 1.9.6
Post by: Adam on February 22, 2012, 05:35:01 PM

Edit: it appears this is a problem with db_old, its fixed in http://anope.git.sourceforge.net/git/gitweb.cgi?p=anope/anope;a=patch;h=81e50dd1f404c9bad008fe1b569dad134df91125

Title: Re: upgrading database to 1.9.6
Post by: lordcow on February 23, 2012, 10:11:05 AM

awesome thanx

Title: Re: upgrading database to 1.9.6
Post by: lordcow on February 24, 2012, 04:38:25 PM

we've checked out 1.9.7-avoid-direct-visual-contact - the memos are retained this time but imported in reverse order.

Title: Re: upgrading database to 1.9.6
Post by: lordcow on February 24, 2012, 05:39:53 PM

the only other issues i can pick up via diff'ing are the channel counts for each botserv bot are being double counted (after we shutdown and remove the db_old module).

Title: Re: upgrading database to 1.9.6
Post by: Adam on February 24, 2012, 07:56:57 PM

Ok thanks, fixed in http://anope.git.sourceforge.net/git/gitweb.cgi?p=anope/anope;a=patch;h=2337b7717db05e0c8b53da2d61b5a66f58cc0297

Title: Re: upgrading database to 1.9.6
Post by: CuttingEdge on February 26, 2012, 10:09:57 AM

Found that 'noexpire' flags within nicknames aren't propagated over either from 1.8.7 to 1.9.7 (latest GIT checkout).  Looks fine for channels.

Title: Re: upgrading database to 1.9.6
Post by: Adam on February 27, 2012, 05:18:42 AM

Ah thanks. It appears early 1.9 changed how that worked so I've changed it back to load 1.8 style databases. If any early 1.9 people are left they're out of luck. Fixed in http://anope.git.sourceforge.net/git/gitweb.cgi?p=anope/anope;a=commitdiff;h=020467d472bc41831756e68ca341d2b166fadceb.

Title: Re: upgrading database to 1.9.6
Post by: CuttingEdge on February 27, 2012, 02:57:36 PM

Thank you kindly!  All working as intended.  :)

Title: Re: upgrading database to 1.9.6
Post by: CuttingEdge on February 27, 2012, 03:00:54 PM

Think I found another bug.  The ChanServ mode lock doesn't show any modes after a conversion either.

See: /msg ChanServ info #channel

Title: Re: upgrading database to 1.9.6
Post by: Jan Milants on February 29, 2012, 08:21:13 AM

mlock was removed in 1.9.6. Use CS MODE instead.
Settings from mlock are not imported into mode..

Title: Re: upgrading database to 1.9.6
Post by: CuttingEdge on February 29, 2012, 05:07:01 PM

Hi Jan,

Thanks for the heads up!  I see now what you mean. :)

*makes a mental note*

--

Title: Re: upgrading database to 1.9.6
Post by: lordcow on March 04, 2012, 09:24:29 PM

Hey, something else - as soon as a host goes over the defaultsessionlimit services crashes.

Title: Re: upgrading database to 1.9.6
Post by: Adam on March 04, 2012, 11:27:34 PM

We need logs and a backtrace to fix that

Title: Re: upgrading database to 1.9.6
Post by: lordcow on March 05, 2012, 12:39:45 PM

our defaultsessionlimit is 3. Services logs in debug mode when sending in 4 sessions:

http://lordcow.org/sessionlimit_logs.txt

At this point services crashes. A backtrace from gdb:

http://lordcow.org/sessionlimit_gdb.txt

Title: Re: upgrading database to 1.9.6
Post by: Adam on March 10, 2012, 08:00:19 PM

try http://adam.anope.org/session.diff

Title: Re: upgrading database to 1.9.6
Post by: lordcow on March 14, 2012, 11:51:27 AM

Hey, nope still crashing.

I'm not sure if I got the modules/commands/os_session.cpp changes right though:

you want me to remove

Code: [Select]

          else
          {
                   u->Kill(Config->OperServ, "Session limit exceeded");
                   u = NULL; /* No guarentee u still exists */
          }

at line 656 and add

Code: [Select]

u->Kill(Config->OperServ, "Session limit exceeded");

at line 647?

Title: Re: upgrading database to 1.9.6
Post by: lordcow on April 05, 2012, 05:06:23 PM

Sorry that patch didn't apply cleanly on 1.9.7-avoid-direct-visual-contact (g92ed5d7) hence the confusion but it did on 1.9.6 stable. 1.9.6 however doesn't suffer from this problem (it doesn't crash with/without the patch). Also, have updated to ge6edc65 and that doesn't crash either.

Title: Re: upgrading database to 1.9.6
Post by: Adam on April 05, 2012, 05:39:48 PM

This was possibly from http://bugs.anope.org/view.php?id=1399