Print

Please login or register.
1 Hour 1 Day 1 Week 1 Month Forever
Login with username, password and session length

[kevin0]

Hey guys, I'm having trouble with a module, I did modify it but I wanted to know if any of you spotted anything wrong.. This is a modified version of Viper's cs_register_operonly and pretty much it checks a DB for information before allowing registering for non-IRCOPS. Anyway, here is a pastebin of the module:

http://pastebin.org/38083

The error returned is:

Code: [Select]

[19:03] -irc.datablab.com- *** Global -- from services.datablab.com: PANIC! buffer = :Kevin0 PRIVMSG cs@services.datablab.com :register #test test test



That's all the error message I get for that module.



The second module giving me trouble (which started giving me trouble randomly) is a modified ircd_init (source here). This one will not work when loaded. Giving me the error:

Code: [Select]

[May 23 19:15:04 2008] Backtrace: not available on Windows [May 23 19:15:04 2008] Running
(Then anope crashes out, same output with -debug)

When I use /os modload ircd_init (which used to work and no edits have been made to the file) I get this error:

Code: [Select]

[May 23 19:17:50 2008] PANIC! buffer = :Kevin PRIVMSG os@services.datablab.com :modload ircd_init


Any help is much appreciated

[Jan Milants]

to answer your first question, you are using strtok which for starters is not threadsafe and shouldn't be used by modules, especialy not if the core also hooks to the same command since it s destructive. Use the non destructive token functions also found in the wiki (http://anope.info/wiki/Modules:QuickList:Tokens)

the second  and third aren't really my domain

[kevin0]

Originally posted by Viper
to answer your first question, you are using strtok which for starters is not threadsafe and shouldn't be used by modules, especialy not if the core also hooks to the same command since it s destructive. Use the non destructive token functions also found in the wiki (http://anope.info/wiki/Modules:QuickList:Tokens)

the second  and third aren't really my domain

Thanks for the tip! Even with that in place though it still seems to be getting the same error every time.

Edit: To test this I pretty much took out most of the function so now it looks like this:

Code: [Select]

char cur_buffer = moduleGetLastBuffer();
char chan = myStrGetOnlyToken(cur_buffer, ' ', 1);
char pass = myStrGetOnlyToken(cur_buffer, ' ', 2);
char desc = myStrGetOnlyToken(cur_buffer, ' ', 3);
alog("chan: %s  -- pass: %s -- desc: %s", chan,pass,desc);
moduleNoticeLang(s_ChanServ, u, LANG_REGISTER_RESTRICTED);
return MOD_STOP;

But it works as

Code: [Select]

LANG_REGISTER_RESTRICTED);
return MOD_STOP;



[Edited on 23-5-2008 by kevin0]

[Edited on 23-5-2008 by kevin0]

[katsklaw]

try using anope_cmd_svsjoin

[kevin0]

Originally posted by katsklaw
try using anope_cmd_svsjoin

Not exactly sure what you mean, If you're talking about the ircd_init script, that is what I'm using.

[katsklaw]

Originally posted by kevin0

Originally posted by katsklaw
try using anope_cmd_svsjoin

Not exactly sure what you mean, If you're talking about the ircd_init script, that is what I'm using.

You missed a few functions. I wouldn't have suggested it if you was using svsjoin everywhere

[kevin0]

Originally posted by katsklaw

Originally posted by kevin0

Originally posted by katsklaw
try using anope_cmd_svsjoin

Not exactly sure what you mean, If you're talking about the ircd_init script, that is what I'm using.

You missed a few functions. I wouldn't have suggested it if you was using svsjoin everywhere

Call me blind but I don't see where you are referring to. The real service bots use the join command because I can do that. Help-bot is an mIRC bot and thus needs the svsjoin. He has svsjoin everywhere he joins... unless I missed one. But all the rest work find with just join.

[kevin0]

As for the first problem I posted, I'm SOO close now. Everything is being formatted correctly and I'm up till after I run the SQL query... Here's the updated code to look at... http://pastebin.org/38136


Only look in oper_only_chan_reg and I get to the point where it logs "into the ret" I get the same error as listed in the first post so it's a problem with that first line after the alog that says "into the ret"... Anyone have an idea of what's wrong with it?

[Jan Milants]

you are passing it mysql, but that variable is never initialised and as far as i know it s not in extern.h either... :S

[kevin0]

Okay, so I've fixed my first issue, the mysql now works correctly and the module is fine. The issue I'm not having with ircd_init seems to be when I load the mod and it joins every channel, channels with weird names cause the error. Examples are: #k3v, #test895, #xXEx3cuti0n3rXx, #test911. There's nothing special about these channels except for their names... Any ideas?