Anope IRC Services

Please login or register.

Login with username, password and session length
Advanced search  

News:

Pages: [1] 2 3 ... 14   Go Down

Author Topic: bs_fantasy_ext (Version 1.4.1 Released - Critical update!)  (Read 251625 times)

0 Members and 1 Guest are viewing this topic.

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
bs_fantasy_ext (Version 1.4.1 Released - Critical update!)
« on: April 29, 2006, 05:27:50 PM »

Because a lot of people have been asking this and well because i must say i liked this module to, i decided to make a a replacement for the old ones. Not all commands that were in the previous modules, nor the access levels to use them are the same. This module uses the same requirements to use the chanserv or botserv commands. So for example because in xop the chanserv topic command is limited to founders, the !topic and !append will only work for channel founders. This can be changed by using levels instead and changing TOPIC

It has been a while since the release of 1.4.0 and a number of bugs have surfaced in that time. However, recently a critical, exploitable infinitely loop vulnerability was discovered in 1.4.0, so there was need for an immediate release. (All versions since 1.3.0 are known to be affected; older versions were not verified.) This release fixes that bug, as well as many other issues that were fixed in the repository over the past year.

So here is is the end result: a 1.4.1 release which addresses all known issues to go with the recently released anope 1.8.8.

Moved the modules download to the modules site: http://modules.anope.org/viewmod.php?id=61

Windows users should be aware that as of now this module does just consist of a .dll, but also needs its own language files to function. The .zip should be extracted into the Anope directory while retaining the directory structure and everything should be fine. For more info read INSTALL included in the archive.

Note that people using RAW or modules to force join non botserv bots into channel will not be supported!!!
Only botserv bots are designed to be in channels and i cannot offer support for this module when anope is in desync because of the unpredictability...

Pls report bugs here instead of sending an email...

Be sure to copy the configuration directives in the code of the module to your services.conf !!! By default a lot is disabled, so check these.

The modules code repository can be accessed on http://git.milanza.org/?p=anope-modules/bs_fantasy_ext;a=summary
« Last Edit: April 30, 2018, 12:37:28 PM by Jan Milants »
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)

Tom65789

  • Anope User
  • Offline Offline
  • Posts: 343
    • www.t65789.co.uk
(No subject)
« Reply #1 on: April 29, 2006, 06:38:22 PM »

This module does NOT yet work on windows !!! < unless you fix it yourself to do so. :P

Trystan Scott Lee

  • Contributor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 343
(No subject)
« Reply #2 on: April 30, 2006, 02:20:48 AM »

Just a note.. the code will not build with gcc2 compilers, this is due to the fact that you can't declare a variable in the middle of the code. This will also like break the code is compiled with anope's strict or MS VC compiler

Also note that // will note compile in ansi

bs_fantasy_ext.c: In function 'do_clear':
bs_fantasy_ext.c:1242: error: expected expression before '/' token
bs_fantasy_ext.c:1251: warning: ISO C90 forbids mixed declarations and code
bs_fantasy_ext.c:1300: warning: ISO C90 forbids mixed declarations and code
bs_fantasy_ext.c:1308: error: 'chan' undeclared (first use in this function)
bs_fantasy_ext.c:1308: error: (Each undeclared identifier is reported only once
bs_fantasy_ext.c:1308: error: for each function it appears in.)
bs_fantasy_ext.c:1323: warning: ISO C90 forbids mixed declarations and code
bs_fantasy_ext.c:1348: warning: ISO C90 forbids mixed declarations and code
bs_fantasy_ext.c: In function 'do_up_down':
bs_fantasy_ext.c:3626: error: expected expression before '/' token
bs_fantasy_ext.c:3627: error: expected expression before '/' token
bs_fantasy_ext.c:3628: error: expected expression before '/' token
bs_fantasy_ext.c:3631: error: expected expression before '/' token
bs_fantasy_ext.c:3631: error: missing terminating ' character
bs_fantasy_ext.c:3636: error: stray '#' in program
bs_fantasy_ext.c: In function 'load_config':
bs_fantasy_ext.c:3695: warning: initializer element is not computable at load time
bs_fantasy_ext.c:3695: warning: initializer element is not computable at load time
bs_fantasy_ext.c:3695: warning: initializer element is not computable at load time
bs_fantasy_ext.c:3695: warning: initializer element is not computable at load time
bs_fantasy_ext.c:3694: warning: ISO C90 forbids mixed declarations and code
bs_fantasy_ext.c: In function 'add_languages':
bs_fantasy_ext.c:3981: warning: string length '1318' is greater than the length '509' ISO C89 compilers are required to support
bs_fantasy_ext.c:4202: warning: string length '2455' is greater than the length '509' ISO C89 compilers are required to support
Logged
my God my tourniquet, return to me salvation

owine

  • Anope User
  • Offline Offline
  • Posts: 130
(No subject)
« Reply #3 on: April 30, 2006, 03:16:42 AM »

this doesnt compile for me. i added that block to my conf but i get

aardwolf@box1:~/anope-1.7.14$ make modules
*** Building src
(cd src/modules ; ./configure ; make 'CFLAGS=-pipe -g -O2 -I/usr/local/include/mysql  -D_THREAD_SAFE -pthread -export-dynamic' 'CC=gcc' 'ANOPELIBS=-lmysqlclient'  'LDFLAGS=-L/usr/local/lib/mysql' 'BINDEST=/home/aardwolf/services' 'INSTALL=/usr/bin/install'  'INCLUDEDIR=../include' 'RM=/bin/rm' 'CP=/bin/cp'  'TOUCH=/usr/bin/touch' 'SHELL=/bin/sh' 'DATDEST=/home/aardwolf/services'  'RUNGROUP=' 'MODULE_PATH=/home/aardwolf/services/modules/' 'RDB=rdb.c' 'MYSQL=mysql.c' 'SHARED=-shared' 'MODULEFLAGS=-fPIC -DPIC -shared' all; )
gcc -pipe -g -O2 -I/usr/local/include/mysql  -D_THREAD_SAFE -pthread -export-dynamic -rdynamic -Wall -fPIC -DPIC -shared -I../../include -c bs_fantasy_ext.c
bs_fantasy_ext.c: In function `do_clear':
bs_fantasy_ext.c:1300: syntax error before `int'
bs_fantasy_ext.c:1302: `count' undeclared (first use in this function)
bs_fantasy_ext.c:1302: (Each undeclared identifier is reported only once
bs_fantasy_ext.c:1302: for each function it appears in.)
bs_fantasy_ext.c:1303: `bans' undeclared (first use in this function)
bs_fantasy_ext.c:1323: syntax error before `int'
bs_fantasy_ext.c:1326: `excepts' undeclared (first use in this function)
bs_fantasy_ext.c:1348: syntax error before `int'
bs_fantasy_ext.c:1351: `invites' undeclared (first use in this function)
bs_fantasy_ext.c: In function `load_config':
bs_fantasy_ext.c:3694: syntax error before `confvalues'
bs_fantasy_ext.c:3697: `confvalues' undeclared (first use in this function)
*** Error code 1

Stop in /home/aardwolf/anope-1.7.14/src/modules.
*** Error code 1

Stop in /home/aardwolf/anope-1.7.14.
Logged

Trystan Scott Lee

  • Contributor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 343
(No subject)
« Reply #4 on: April 30, 2006, 03:44:34 AM »

I'll take a wild stab and say freebsd and gcc2 compiler.. if so this is what I was pointing out to him already
Logged
my God my tourniquet, return to me salvation

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
(No subject)
« Reply #5 on: April 30, 2006, 10:40:56 AM »

Trystan, i don't have axx to a linux box with a gcc2 compiler so didn't really know it made such a big difference... any way i can test this on windows ? ... a syntax checker or a strict compiler or so would be nice...

btw, could MS VS do this ?

edit: maybe not with VS because i ve just been reading a bit and apparently anope doesn't work very well with .Net Framework v2 ans can't downgrade cause i need it for college...

[Edited on 30-4-2006 by Viper]
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)

owine

  • Anope User
  • Offline Offline
  • Posts: 130
(No subject)
« Reply #6 on: April 30, 2006, 04:00:25 PM »

Quote
Originally posted by Trystan
I'll take a wild stab and say freebsd and gcc2 compiler.. if so this is what I was pointing out to him already

heh... i know it is freebsd and gcc 2.9.5 so yes.
Logged

Trystan Scott Lee

  • Contributor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 343
(No subject)
« Reply #7 on: April 30, 2006, 05:20:29 PM »

Viper you don't need gcc2 really just build anope with its "make strict" and fix those errors, I could get win32 setup but it will take a few, most of the problems with win32 can be resolved by fixing any problems with make strict
Logged
my God my tourniquet, return to me salvation

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
(No subject)
« Reply #8 on: April 30, 2006, 06:03:19 PM »

ok.. i think it s done
owine, try it again now, link updated
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)

Tom65789

  • Anope User
  • Offline Offline
  • Posts: 343
    • www.t65789.co.uk
(No subject)
« Reply #9 on: April 30, 2006, 06:14:14 PM »

i'll try it on Win32 for you :P

now we love errors so much heres a nice list(shorter than what it was at first :P)

bs_fantasy_ext.c
bs_fantasy_ext.c(1300) : error C2143: syntax error : missing ';' before 'type'
bs_fantasy_ext.c(1301) : error C2143: syntax error : missing ';' before 'type'
bs_fantasy_ext.c(1302) : error C2065: 'count' : undeclared identifier
bs_fantasy_ext.c(1303) : error C2065: 'bans' : undeclared identifier
bs_fantasy_ext.c(1303) : error C2109: subscript requires array or pointer type
bs_fantasy_ext.c(1307) : error C2109: subscript requires array or pointer type
bs_fantasy_ext.c(1313) : warning C4022: 'free' : pointer mismatch for actual parameter 1
bs_fantasy_ext.c(1323) : error C2143: syntax error : missing ';' before 'type'
bs_fantasy_ext.c(1324) : error C2143: syntax error : missing ';' before 'type'
bs_fantasy_ext.c(1326) : error C2065: 'excepts' : undeclared identifier
bs_fantasy_ext.c(1326) : error C2109: subscript requires array or pointer type
bs_fantasy_ext.c(1330) : error C2109: subscript requires array or pointer type
bs_fantasy_ext.c(1336) : warning C4022: 'free' : pointer mismatch for actual parameter 1
bs_fantasy_ext.c(1348) : error C2143: syntax error : missing ';' before 'type'
bs_fantasy_ext.c(1349) : error C2143: syntax error : missing ';' before 'type'
bs_fantasy_ext.c(1351) : error C2065: 'invites' : undeclared identifier
bs_fantasy_ext.c(1351) : error C2109: subscript requires array or pointer type
bs_fantasy_ext.c(1355) : error C2109: subscript requires array or pointer type
bs_fantasy_ext.c(1361) : warning C4022: 'free' : pointer mismatch for actual parameter 1
bs_fantasy_ext.c(3694) : error C2275: 'Directive' : illegal use of this type as an expression
        z:\Anope\include\services.h(410) : see declaration of 'Directive'
bs_fantasy_ext.c(3694) : error C2146: syntax error : missing ';' before identifier 'confvalues'
bs_fantasy_ext.c(3694) : error C2144: syntax error : '<Unknown>' should be preceded by '<Unknown>'
bs_fantasy_ext.c(3694) : error C2144: syntax error : '<Unknown>' should be preceded by '<Unknown>'
bs_fantasy_ext.c(3694) : error C2143: syntax error : missing ';' before 'identifier'
bs_fantasy_ext.c(3694) : error C2065: 'confvalues' : undeclared identifier
bs_fantasy_ext.c(3694) : error C2059: syntax error : ']'
bs_fantasy_ext.c(3697) : warning C4047: 'function' : 'Directive *' differs in levels of indirection from 'int'
NMAKE : fatal error U1077: 'cl' : return code '0x2'
Stop.

[Edited on 30-4-2006 by Tom65789]

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
(No subject)
« Reply #10 on: April 30, 2006, 07:09:53 PM »

ohhh... that s sooo ... *** friendly *** of you .... :r

/Me reminds Tom of what he thinks about win32.....
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)

Tom65789

  • Anope User
  • Offline Offline
  • Posts: 343
    • www.t65789.co.uk
(No subject)
« Reply #11 on: April 30, 2006, 07:12:19 PM »

its actually known as Winblows :)

owine

  • Anope User
  • Offline Offline
  • Posts: 130
(No subject)
« Reply #12 on: April 30, 2006, 07:12:41 PM »

yes... it does viper... much thanks... very nice
Logged

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
(No subject)
« Reply #13 on: April 30, 2006, 09:02:07 PM »

i fail to see what s the problem with compiling it on windows and since i don't know how to do this myself (if i even can with .Net framework v2)... can't really play around with it either so :r

at least it should work fine on all *nix now :)
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)

Trystan Scott Lee

  • Contributor
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 343
(No subject)
« Reply #14 on: April 30, 2006, 11:22:23 PM »

It is the same problem was with make strict on linux, except on win32 it is an error not a warning
Logged
my God my tourniquet, return to me salvation

owine

  • Anope User
  • Offline Offline
  • Posts: 130
(No subject)
« Reply #15 on: May 01, 2006, 12:01:12 AM »

!mute crashes the module for me. i get a panic in the logchan and then services freezes up and i have to kill -9 it.
Logged

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
(No subject)
« Reply #16 on: May 01, 2006, 12:22:37 AM »

i got no errors/warnings on making it with make strict though..  so dunno where all those on win32 came from...  i tought i fixed the place where they had to be defined :s

owine, knowing your ircd would be handy... (might also wanna paste the segfault)

edit: i ve been rewriting the mute function, and stumbled upon a segfault as well... may very well have the same cause.. to late to fix now though ** me of to bed

[Edited on 1-5-2006 by Viper]
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)

owine

  • Anope User
  • Offline Offline
  • Posts: 130
(No subject)
« Reply #17 on: May 01, 2006, 01:21:54 AM »

PANIC! buffer = :owine PRIVMSG #chan :!mute someone
latest unreal.
Logged

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
(No subject)
« Reply #18 on: May 01, 2006, 10:13:24 AM »

weid... i had tested it on unrealircd though... download the module again and try it again... it works fine for me... i rewrote !mute a bit, maybe that ll solve the problem

if this doesn 't solve it, i like to know exactly what you are typing before it crashes and the bantype used by that channel

edit: if it does solve it pls tell me so...

[Edited on 1-5-2006 by Viper]
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)

owine

  • Anope User
  • Offline Offline
  • Posts: 130
(No subject)
« Reply #19 on: May 01, 2006, 11:17:43 PM »

works Viper. much thanks.
Logged

TRAiNER4

  • Guest
(No subject)
« Reply #20 on: May 04, 2006, 03:31:57 AM »

a few bugs.... 1) !ban only sets +b on the person and doesn't kick, though !kb would do that... 2) !unban has the services server unset it, not the BotServ bot


Quote
[10:34:10p] <@TRAiNER4> !ban
[10:34:10p] ::: Mode : (BonJovi) sets mode: -o (TRAiNER4)
[10:34:10p] ::: Mode : (BonJovi) sets mode: +b (*!*@DLDtk-2489E213)
[10:34:12p] <TRAiNER4> !unban
[10:34:12p] ::: Mode : (services.dldtk-irc.net) sets mode: -b (*!*@DLDtk-2489E213)

or
Quote
[10:37:56p] <@TRAiNER4> !ban Joseph11
[10:37:57p] ::: Mode : (BonJovi) sets mode: -h (Joseph11)
[10:37:57p] ::: Mode : (BonJovi) sets mode: +b (*!*@DLDtk-99EF2957.bed.freedialup.org.dialup.g4.net)
[10:38:00p] <@TRAiNER4> !unban Joseph11
[10:38:00p] ::: Mode : (services.dldtk-irc.net) sets mode: -b (*!*@DLDtk-99EF2957.bed.freedialup.org.dialup.g4.net)

[Edited on 5/4/2006 by TRAiNER4]
Logged

owine

  • Anope User
  • Offline Offline
  • Posts: 130
(No subject)
« Reply #21 on: May 04, 2006, 04:29:47 AM »

thats what !ban does... just a ban no kick.
Logged

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
(No subject)
« Reply #22 on: May 04, 2006, 06:27:22 PM »

!unban is implemented by the anope core as is !kick and !kb... so can't change those unless i d decide to build those in in the module as well and require users to unload those core modules... still thinking about that

and yes !ban does exactly what the words says, banning the user without kicking him

edit: i have no idea why sometimes the core uses the botserv client, and sometimes the services server... you should ask the devs about that.. i can't answer it

[Edited on 4-5-2006 by Viper]
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)

TRAiNER4

  • Guest
(No subject)
« Reply #23 on: May 05, 2006, 12:54:38 AM »

ok I found another segfault problem... I type !mute <name of botserv bot in channel here> and it kicks me with Oops! but then segfaults the services. =/
Logged

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
(No subject)
« Reply #24 on: May 05, 2006, 09:22:57 AM »

ok i ll look at this the sec i get home... can't ssh from college to home box

edit: try again now, uploaded a fixed version (i hope)... works for me

i was able to reproduce the crash however it happened sometimes, not every time i muted the bot so not sure y... moved the free()'s,  my guess is it crashed over those

[Edited on 5-5-2006 by Viper]
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)
Pages: [1] 2 3 ... 14   Go Up