Anope IRC Services

Anope Support => 1.6.x (Read Only) => Topic started by: PharLap on August 03, 2006, 08:18:07 AM

Title: [BUG] malformed numeric 307
Post by: PharLap on August 03, 2006, 08:18:07 AM
Line 1014 of messages.c reads as:

Code: [Select]
send_cmd(ServerName, "307 %s :%s is a registered nick", source,

I believe the correct format would be
Code: [Select]
send_cmd(ServerName, "307 %s %s :is a registered nick", source,

- Phar Lap -

Argh, I forgot to ask if this reply is necessary at all? The problem is that you have to hardcode this 307-reply message but when someone whoises a normal identified user, the IRCd will reply with its own message which can be a bit different ("has identified for this nick").
So why not just leave it all up to IRCd and set +r on BOTSERV created nicks OR just don't reply a 307 for them at all?

Opinions please!

[Edited on 3-8-2006 by PharLap]
Post by: Pieter Bootsma on August 03, 2006, 09:52:56 AM
We have to catch WHOIS as well, because a whois command can be forwarded to another server (for example the one the user is on), and the server HAS to reply to that whois. We can't just leave it to the IRCd...