Anope IRC Services

Anope Development => Modules => Topic started by: Andi on July 17, 2006, 05:17:56 PM

Title: [bs_moremodesperline] segfault
Post by: Andi on July 17, 2006, 05:17:56 PM
Hi!

The module bs_moremodesperline v1.05 (by SGR & ProjectDEAD) causes a segfault in anope 1.7.14. Here is the backtrace


Code: [Select]
#0  0x4023ac7f in strlen () from /lib/libc.so.6
#1  0x4020e3a5 in vfprintf () from /lib/libc.so.6
#2  0x4022c310 in vsnprintf () from /lib/libc.so.6
#3  0x08080612 in vsend_cmd (source=0x83cde20 "InterneteXploder",
    fmt=0x2889 <Address 0x2889 out of bounds>, args=0x0) at send.c:53
#4  0x080805c3 in send_cmd (source=0x0,
    fmt=0x2889 <Address 0x2889 out of bounds>) at send.c:33
#5  0x4045a07d in mynewmsg (u=0x83d6cb8, ci=0x83cfcb0)
    at bs_moremodesperline.c:525
#6  0x40459d49 in my_privmsg (source=0x0, ac=2, av=0x0)
    at bs_moremodesperline.c:102
#7  0x080803f6 in process () at process.c:278
#8  0x08070168 in main (ac=1, av=0xbffffd94, envp=0xbffffda4) at main.c:600

Full backtrace:
Code: [Select]
#0  0x4023ac7f in strlen () from /lib/libc.so.6
No symbol table info available.
#1  0x4020e3a5 in vfprintf () from /lib/libc.so.6
No symbol table info available.
#2  0x4022c310 in vsnprintf () from /lib/libc.so.6
No symbol table info available.
#3  0x08080612 in vsend_cmd (source=0x83cde20 "InterneteXploder",
    fmt=0x2889 <Address 0x2889 out of bounds>, args=0x0) at send.c:53
        buf = "MODE #funirc +ooooo: Robby `235E@À_ab`dab`006b6232E@220Ç#@ 05bb Yabv232E@ 234E@,»E@Ø6fbdütbÐf37@ ", '' <repeats 168 times>, "0423#@[Jul 17 17:48:20.458034 2006] 005130000000000Þûÿ¿ÀH/@ÿ030000à÷ÿ¿È÷ÿ¿20Ã"@Üöÿ¿22740@(üÿ¿à÷ÿ¿00000000|÷ÿ¿Üöÿ¿01200­ûà÷ÿ¿à÷"...
#4  0x080805c3 in send_cmd (source=0x0,
    fmt=0x2889 <Address 0x2889 out of bounds>) at send.c:33
No locals.
#5  0x4045a07d in mynewmsg (u=0x83d6cb8, ci=0x83cfcb0)
    at bs_moremodesperline.c:525
        cmd = 0x83d66b8 "!op"
        text = 0x404594f8 "M01"
        param1 = 0x404594f8 "M01"
        params = 0x83c21bc "Robby"
        i = 1078302581
tmp = 0x404594f8 "M01"
        param = {0x83d6c28 "Robby",
  0x4045bae4 "`235E@À_ab`dab`006b6232E@220Ç#@ 05bb Yabv232E@ 234E@,»E@Ø6fbdütbÐf37@", 0x2b <Address 0x2b out of bounds>,
  0x40459775 "mynewmsg", 0x404594f8 "M01"}
        dowhat = 2
#6  0x40459d49 in my_privmsg (source=0x0, ac=2, av=0x0)
    at bs_moremodesperline.c:102
        u = (User *) 0x83d6cb8
        ci = (ChannelInfo *) 0x2889
#7  0x080803f6 in process () at process.c:278
        retVal = 0
        current = (Message *) 0x83dbde8
        source = "bitnapper", '' <repeats 19 times>, "¸rrb00000026n00000000000000 kfbD±»Dÿÿÿÿøüÿ¿3Gbb"
        cmd = "PRIVMSG0000±»D200üÿ¿1360000@S/@tr#@00000000A3637@AU77H000000åÈabho=b24Û.@0500000023123123131"
        buf = "PRIVMSG00#funirc00:!op Robby00:!op Robby", '' <repeats 167 times>, ">°35@r000000a000000ðûÿ¿230@bbb000000pûÿ¿0000000000000000hûÿ¿", '' <repeats 12 times>, "T000000hûÿ¿", '' <repeats 140 times>, "22740@30üÿ¿r000000Ú030000ÆkfbØüÿ¿ÖFbba000000@üÿ¿00000000000000008üÿ¿D±»D00000000200üÿ¿220«<bD±»D0500000000000000@000000200üÿ¿D"...
 s = 0x83dbde8 "È£=b 234E@"
        ac = 2
        av = (char **) 0x83d6820
        m = (Message *) 0x83dbde8
#8  0x08070168 in main (ac=1, av=0xbffffd94, envp=0xbffffda4) at main.c:600
        t = 1153151300
        last_update = 1153151205
        last_expire = 1153151205
        last_check = 1153151300
        last_DefCon = 1153151205
        i = 0
        progname = 0xbffffe84 "services"

Unfortunately the orignal authors are inactive. So it would be nice, if anyone else can fix this.

Thanks in advance!

Andi
Title:
Post by: TRAiNER4 on July 18, 2006, 05:08:17 PM
you got the link to the module? maybe I'll take a gander at it, since I've been studying the anope source for some time now.

EDIT: ok I found it, http://www.anope.org/modules/bs_moremodesperline.c

I'll take a look at this and see if there's anything I can do for it.

[Edited on 7/18/2006 by TRAiNER4]
Title:
Post by: Andi on July 18, 2006, 05:22:30 PM
Quote
Originally posted by TRAiNER4
http://www.anope.org/modules/bs_moremodesperline.c

I'll take a look at this and see if there's anything I can do for it.


yeah, that's it.

Thank you for your time dealing with this!
Title:
Post by: TRAiNER4 on July 18, 2006, 05:25:15 PM
Unfortunately to say, this module does not build properly for unreal I'm afraid, sorry. I am unable to help you find the problem.
Title:
Post by: Andi on July 18, 2006, 05:35:31 PM
Hmmm,

we are using unreal too, but had no problems with compiling...
Title:
Post by: Tom65789 on July 18, 2006, 05:36:02 PM
its works on Unreal..... just needs updating lol. seems like a quite outdated module tbh. i would suggest updating the code
Title:
Post by: Andi on July 18, 2006, 05:42:08 PM
Yes this module is very old. But I haven't the expierience neither in c (c is to old for me) nor in the anope coding style.

Maybe an active module coder has time to update the code.
Title:
Post by: Tom65789 on July 18, 2006, 05:50:26 PM
i might find time, i'll see if i can be bothered to take a look when im finished with my code
Title:
Post by: Charles Kingsley on July 18, 2006, 09:34:18 PM
I'd appreciate it Tom if you could help Andi out.

Thanks mate.
Title:
Post by: Tom65789 on July 20, 2006, 05:58:45 PM
kk i did a quick update job on it, might be a problem or 2 with it but i really was short of time when i did it lol!

EDIT: ok there is one issue, will try to fix it asap

[Edited on 20-7-2006 by Tom65789]
Title:
Post by: Charles Kingsley on July 20, 2006, 06:09:51 PM
Hi, as requested, tested, seems good to go.
Title:
Post by: Tom65789 on July 20, 2006, 08:50:12 PM
lol, if there are any bugs just let me know :)
Title:
Post by: Andi on July 20, 2006, 09:02:23 PM
Thanks alot Tom65789 for updating that module that fast!
I also want to thank chaz for his engagement and for his testing!

Very good job you two.

Thanks again!
Title:
Post by: Tom65789 on July 20, 2006, 09:10:49 PM
Andi, there is one combination that will kill your box, unload it asap, then wait til i have a fixed version. sorry about that
Title:
Post by: Charles Kingsley on July 20, 2006, 09:12:01 PM
Which I found! And it caused 20000% loads on my box and almost killed it. Also caused 1.5GB ram usage on toms.

Unload it now!
Title:
Post by: Andi on July 20, 2006, 09:19:31 PM
oooooooooops, i became the notification email before i loaded the module, so nothing happened...

Do you know what's causing that trouble?
Title:
Post by: Charles Kingsley on July 20, 2006, 09:22:56 PM
Yeah, I emailled you to make sure you got it unloaded.

It totalled my box ... and then Tom's.

I'm sure he'll fix it, and we now know what to do to upset it ;)
Title:
Post by: Tom65789 on July 20, 2006, 09:26:16 PM
lol which means i know what t put where to debug it