Anope IRC Services

Please login or register.

Login with username, password and session length
Advanced search  

News:

Pages: [1]   Go Down

Author Topic: MemoServ - do not let anyone MemoServ any room  (Read 5930 times)

0 Members and 1 Guest are viewing this topic.

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
MemoServ - do not let anyone MemoServ any room
« on: September 03, 2006, 04:51:01 AM »

with MemoServ,  anyone can send MemoServ's to any room

it would be nice to only let those people who are on that room's Access List to MemoServ to that room --- enabled by default

and not let anyone MemoServ to any room
Logged

n00bie

  • Anope User
  • Offline Offline
  • Gender: Male
  • Posts: 411
(No subject)
« Reply #1 on: September 11, 2006, 12:25:47 PM »

I'm not sure whether this feature will be included in the core services. However, i created a module for it ^^

Description:
Using this module, only users who are on the channel access list (HalfOp and above)
will be able to send memos to the channel.

http://noobie.esmartkid.com/mymods/ms_limitsend.c
Logged
I am always doing things that which I cannot do, in order that I may learn how to do it.

Jan Milants

  • Team
  • *
  • Offline Offline
  • Gender: Male
  • Posts: 1372
(No subject)
« Reply #2 on: September 11, 2006, 04:41:06 PM »

you fixed a few leaks allready after i told you i see, but not all ...

Code: [Select]
notice_lang(s_ChanServ, u, CHAN_X_NOT_REGISTERED, target);
free(target);

should be
Code: [Select]
notice_lang(s_ChanServ, u, CHAN_X_NOT_REGISTERED, target);
free(text);
free(target);


same goes for next if statement

and also this one, it s missing both..

Code: [Select]
} else if (!nick_identified(u)) {
notice_lang(s_MemoServ, u, NICK_IDENTIFY_REQUIRED, s_NickServ);
return MOD_STOP;
} else {

should be
Code: [Select]
} else if (!nick_identified(u)) {
notice_lang(s_MemoServ, u, NICK_IDENTIFY_REQUIRED, s_NickServ);
free(text);
free(target);
return MOD_STOP;
} else {


+ 2 more... but i guess you get my point ? :)

[Edited on 11-9-2006 by Viper]
Logged
If you like me donate coins to 1FBmZVT4J8WAUMHKqpWhgNVj3XXnRN1cCk :)

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
(No subject)
« Reply #3 on: September 12, 2006, 06:59:15 AM »

I find this really should be in the core services to not let anyone MemoServ any room

it should really be for the OPs of the room to MemoServ the other OPs of the room - or maybe otherwise
Logged

Dave Robson

  • Team
  • *
  • Offline Offline
  • Posts: 357
(No subject)
« Reply #4 on: September 12, 2006, 07:17:45 AM »

The feature was ( iirc ) originally added to allow non-ops in a large channel a means of contacting the channel staff with questions, rules, bans, etc..   Personally i would expect the channel ops to, well, know the other ops and not need a generic /ms tag for them.

That aside, i dont see why this should be in the core, a module can do it just as well as any core feature can.
Logged

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
(No subject)
« Reply #5 on: September 12, 2006, 01:00:42 PM »

no worries - Thanks Rob

I have tried to compile the ms_limitsend.c module for Windows but could not compile it at all with the Visual C++ Studio Express and Windows Platform SDK that it comes up with no suitable build tools were found and tried to compile with the nmake -f Makefile.win32 and nmake -f Makefile.win32 install which it came up with 0 files copied with the ms_limitsend.c in the Makefile.inc.win32

This is on Windows Server 2003 Enterprise Edition with the tar.gz Anope 1.7.15


would you be able to compile it for Windows to get from you ?
Logged

n00bie

  • Anope User
  • Offline Offline
  • Gender: Male
  • Posts: 411
(No subject)
« Reply #6 on: September 12, 2006, 01:12:36 PM »

Hello Casey, i don't want to upset you ... but umm... can you please give me a little more time for that module. I'm currently working on it for an update. Thanks :)
Logged
I am always doing things that which I cannot do, in order that I may learn how to do it.

Casey

  • Anope User
  • Offline Offline
  • Posts: 53
(No subject)
« Reply #7 on: September 12, 2006, 01:24:41 PM »

Thank You n00bie

I am just playing with it at the moment - looking at June 2007 to start
Logged
Pages: [1]   Go Up